scripts: gen_relocate_app.py: fix undefined _ADDR #34331
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the addition of #34185, it is not longer gauranteed that for a memory region `NAME` there exists a symbol `NAME_ADDR`. Use the linker builtin function `ORIGIN` to instead directly get the start address of the selected memory region. Signed-off-by: Jordan Yates <[email protected]>
|
@MaureenHelm should we add the NOR XIP example to the ci builds? |
dcpleung
approved these changes
Apr 16, 2021
MaureenHelm
approved these changes
Apr 16, 2021
There was a problem hiding this comment.
@JordanYates thanks for the quick turnaround! I confirm this fixes the issue.
should we add the NOR XIP example to the ci builds?
@pdgendt Yes!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the addition of #34185, it is not longer gauranteed that for a
memory region
NAMEthere exists a symbolNAME_ADDR. Use the linkerbuiltin function
ORIGINto instead directly get the start address ofthe selected memory region.
This should fix the issue reported after merging #34185
Signed-off-by: Jordan Yates [email protected]